Expensify Unapproved Cash List Doesn't Refresh After Approving Reports

Hey guys! 👋 We've got a situation here with the Unapproved Cash list in Expensify, and I wanted to break it down for you in a way that's super clear and easy to understand. This article dives deep into an issue where the Unapproved Cash list isn't refreshing automatically after you approve expense reports, especially those with multiple expenses. It's a bit of a snag, but we're on it! Let's get into the details, why this is happening, and what it means for you.

The Issue: Unapproved Cash List Woes

So, the main problem we're tackling is that the Unapproved Cash list isn't updating in real-time after you approve an expense report. Imagine you're an admin, logged in, ready to clear out those pending reports. You go to Reports > Unapproved Cash, spot a report with several expenses, and hit that glorious "Approve" button. You'd expect the list to update, right? To show that the report is gone, the total expense count to decrease, and everything to be smooth sailing. But, that's not quite what's happening.

Instead, the approved report is stubbornly sticking around in the list. The total expense count? Unchanged. It's like the system is stuck in time! To see the updated state, you've got to manually refresh the page. This is more than just a minor inconvenience, guys. It can lead to confusion, double approvals, and a less-than-ideal user experience. And, to top it off, reports with multiple expenses can't be approved directly from the list. You've got to dive into the report details first. Talk about a detour!

Why This Matters

Now, you might be thinking, "Okay, it's a refresh issue. Big deal." But trust me, in the world of financial management, accuracy and efficiency are key. This glitch can throw a wrench in both. Imagine an organization processing hundreds, even thousands, of expense reports. Manual refreshing? That's a time sink. And the risk of missing something or making a mistake? It goes way up. We need a system that's as reliable as it is user-friendly, and that means making sure lists update automatically. Plus, the inconsistency in how reports with multiple expenses are handled adds an extra layer of complexity that nobody needs.

Steps to Reproduce the Issue

For those of you who like to get your hands dirty and see the problem in action, here's how you can reproduce this issue:

1. First, log in as an admin of a workspace where approvals and payments are enabled. This sets the stage for the typical approval workflow.
2. Make sure there are reports with multiple expenses waiting for approval. This is crucial because the issue seems to be more pronounced with these types of reports.
3. Navigate to "Reports > Unapproved Cash" from the left-hand menu. This is where you'll see the list of pending reports.
4. Find a report with multiple expenses. Notice that it only shows a “View” button, hinting at the limited actions you can take directly from the list.
5. Click "View" to open the expense details. Then, click on the report name in the header. This takes you to the full report view.
6. From the report details view, click "Approve." This is the action that should trigger an update in the Unapproved Cash list.
7. Press the back button in the app twice to return to the Unapproved Cash list. This is where you'll see whether the list updates correctly.

If the issue is present, the report you just approved will still be visible in the list, and the total count and amount will be unchanged. You'll need to manually refresh the page to see the updated state. This step-by-step guide helps pinpoint the problem and ensures we're all on the same page when discussing it.

Expected vs. Actual Results: A Clear Contrast

To really drive home the issue, let's break down what we expect to happen versus what's actually happening. This side-by-side comparison makes the problem crystal clear.

Expected Result:

• The report vanishes: After approval, the report should disappear from the Unapproved Cash list. It's been approved, it's done, it should be gone! ✅
• Numbers update: The total expense count and amount should decrease accordingly. We're talking real-time updates, guys. 📉
• Consistency is key: The approval flow should be the same, regardless of how many expenses are in the report. One-expense report or a hundred, approval should be approval. 🔑

Actual Result:

• The report lingers: The approved report is still visible in the Unapproved Cash list. It's like that guest who just doesn't want to leave. 🤦
• Numbers don't budge: The total count and amount remain unchanged. It's as if the approval never happened. 🔢
• Manual refresh needed: You've got to manually refresh the page to see the updated state. Talk about extra work! 🔄
• Limited direct approval: Reports with multiple expenses can’t be approved directly from the list. This adds an extra step and breaks the flow. 🚫

The contrast between these expected and actual results highlights the core issue: the Unapproved Cash list isn't behaving as it should. It's not updating in real-time, it's not handling multi-expense reports smoothly, and it's creating extra work for users. This comparison helps everyone understand the scope of the problem and why it needs a fix.

Digging Deeper: Technical Details and Impact

Alright, let's get a bit more technical and talk about the specifics. The version number where this issue was spotted is v9.1.87-1. This is important because it helps the development team pinpoint exactly when the problem started. The issue is reproducible in the staging environment, which is great news because it means we can test fixes thoroughly before they hit the production environment. However, because this is a new feature, it doesn't exist in the production environment yet, so no need to worry about it affecting live users just yet!

This issue was caught during regression testing, specifically related to this pull request on GitHub. Regression testing is crucial because it ensures that new changes don't break existing functionality. The fact that this was caught in testing means the system is working as it should to find and flag these issues before they cause bigger problems.

The issue was reported by the Applause Internal Team, using the email address applausetester+dp265@applause.expensifail.com. The device used for testing was a Mac/Web setup. This kind of detailed information helps the development team understand the context of the issue and how it was discovered.

Platform Breakdown

This bug isn't picky – it's showing up across a range of platforms. Here’s a quick rundown:

• ✅ Android: App
• ✅ Android: mWeb Chrome
• ✅ iOS: App
• ❌ iOS: mWeb Safari
• ✅ iOS: mWeb Chrome
• ✅ Windows: Chrome
• ✅ MacOS: Chrome / Safari
• ❌ MacOS: Desktop

As you can see, it's affecting everything from Android and iOS apps to web browsers on Windows and macOS. The exceptions are iOS mWeb Safari and MacOS Desktop, which don't seem to be affected. This kind of platform-specific information is super valuable for developers as they work on a fix. It helps them narrow down the problem and understand if it's related to specific environments or browsers.

Visual Evidence

To really nail down the issue, there's a helpful screenshot/video available here. Visual evidence is gold in bug reporting. It shows exactly what's happening, eliminating any ambiguity. A picture is worth a thousand words, right? This visual aid helps developers see the problem firsthand, making it easier to diagnose and fix.

The Quest for a Workaround and the Path to a Fix

Currently, there's no known workaround for this issue. That means users are stuck manually refreshing the page to see the updated Unapproved Cash list. Not ideal, but at least we're aware of it. This lack of a workaround underscores the importance of getting a proper fix in place.

What's Next?

The next step is for the development team to dive into the code and figure out why this refresh issue is happening. They'll likely look at the code responsible for updating the Unapproved Cash list after an approval and see why it's not triggering correctly. They might also investigate how multi-expense reports are handled differently and if that's contributing to the problem.

Once they've identified the root cause, they'll develop a fix. This will involve writing new code or modifying existing code to ensure the list updates automatically after an approval, regardless of the number of expenses in the report. The fix will then be tested thoroughly in the staging environment to make sure it resolves the issue without introducing any new problems.

After successful testing, the fix will be rolled out to the production environment. This is where the corrected code goes live and starts benefiting all users. The deployment process is carefully managed to minimize any disruption and ensure a smooth transition.

Open Jobs and Contributing

If you're a developer and this kind of challenge excites you, there's a whole list of open jobs on GitHub related to Expensify development. You can check them out here. Contributing to open-source projects like this is a fantastic way to learn, improve your skills, and make a real impact.

And if you're interested in contributing to Expensify, be sure to check out their contributing guidelines for onboarding. You can also email contributors@expensify.com to request to join their Slack channel. Getting involved in the community is a great way to stay informed, collaborate with other developers, and contribute to the project's success.

Conclusion: Staying Patient and Proactive

So, that's the scoop on the Unapproved Cash list issue in Expensify. It's a bit of a snag, but the team is aware, and a fix is in the works. In the meantime, knowing the issue exists and understanding its scope can help you work around it (manual refreshing, for now!) and avoid any potential confusion. We've walked through the issue, the technical details, the impact, and the steps being taken to resolve it. Transparency and communication are key, and by keeping you in the loop, we're all better equipped to navigate these challenges.

Remember, software development is an ongoing process, and bugs are a part of the journey. The important thing is how we address them. With a clear understanding of the problem, a dedicated team working on a solution, and a supportive community, we're confident this will be resolved soon. Thanks for sticking with us, and stay tuned for updates! We'll continue to keep you informed as progress is made. And hey, if you're a developer looking for a challenge, check out those open jobs – you might just be the one to help us squash the next bug!